Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url encode/decode status-message header #271

Merged
merged 2 commits into from
Oct 12, 2022
Merged

url encode/decode status-message header #271

merged 2 commits into from
Oct 12, 2022

Conversation

drowzy
Copy link
Contributor

@drowzy drowzy commented Sep 6, 2022

Closes #269. As mentioned in the issue uses URI.encode/1 to encode status message trailer grpc-message on the server and decodes the value on the client using URI.decode.

beligante
beligante approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@beligante beligante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@polvalente polvalente merged commit b85a393 into elixir-grpc:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente approved these changes

@beligante beligante beligante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-message is not percent-encoded as specified in the gRPC HTTP/2 spec
3 participants
@drowzy @beligante @polvalente