fix: restore deprecated interceptor modules #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PR elixir-grpc#289, the `GRPC.ServerInterceptor` and `GRPC.ClientInterceptor` is suddenly remove. This could make breaking changes. This changes restore it and add deprecated to `@moduledoc` to those interceptors.
|
Although this makes sense, I'm not sure if the overhead of maintaining both versions is worth it. |
|
Unfortunately. The upcoming version would break my codebase if this PR is not applied. But it's easy to change. :) For the grpc prometheus, we may need this library to release before changing it since it's an external library. |
|
We'll probably deprecate the Prometheus library :) I'll merge this. I think it's nice to warn for at least 1 version on the deprecation. |
Agreed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the compilation warning in interop tests since PR #289 was merged. Because of GRPC Prometheus didn't change to use the new interceptor module. And it's suddenly breaking changes. So I propose to bring it back but add the deprecated module to it. The rest topic is discussing when to remove it. :)