Handle not exception errors from the server #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avillen
force-pushed
the
return-errors-from-server
branch
from
d6706ec
to
5330612
Compare
polvalente
reviewed
Jun 15, 2023
Comment on lines
379
to
384
| {:ok, _stream, error = %GRPC.RPCError{message: nil, status: status}} -> | ||
| {:error, %{error | message: GRPC.Status.status_message(status)}} | ||
|
|
||
| {:ok, _stream, error = %GRPC.RPCError{}} -> | ||
| {:error, error} | ||
|
|
There was a problem hiding this comment.
I believe more changes are needed so that we get this errors to bubble up without raising. Currently they still raise on like 364.
The idea is that if we manage to bubble them up, then they'll bypass any exception-handling workflow and they'll also follow all interceptors along instead of cutting the workflow dry after the call
There was a problem hiding this comment.
Surely I'm wrong, but I'm understanding that those exits are because that part of the code is executed with a spawn_link + Process.flag(:trap_exit, true). I have updated the Server module to return an error tuple that in fact is what I think the logger interceptor expects. I'm missing something no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #316 (comment)