Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB guides improvements #1229

Merged
merged 4 commits into from
Feb 19, 2019
Merged

EPUB guides improvements #1229

merged 4 commits into from
Feb 19, 2019

Conversation

milmazz
Copy link
Member

@milmazz milmazz commented Feb 19, 2019

This PR includes the following changes:

As a side note, I checked the guides against epubcheck and everything appears to be working correctly:

~/D/e/e/_epub *master λ java -jar ~/Downloads/epubcheck-4.1.1/epubcheck.jar elixir-getting-started-guide.epub
Validating using EPUB version 3.0.1 rules.
No errors or warnings detected.
Messages: 0 fatal / 0 errors / 0 warnings / 0 info

EPUBCheck completed
~/D/e/e/_epub *master λ java -jar ~/Downloads/epubcheck-4.1.1/epubcheck.jar mix-and-otp.epub
Validating using EPUB version 3.0.1 rules.
No errors or warnings detected.
Messages: 0 fatal / 0 errors / 0 warnings / 0 info

EPUBCheck completed
~/D/e/e/_epub *master λ java -jar ~/Downloads/epubcheck-4.1.1/epubcheck.jar meta-programming-in-elixir.epub
Validating using EPUB version 3.0.1 rules.
No errors or warnings detected.
Messages: 0 fatal / 0 errors / 0 warnings / 0 info

@josevalim josevalim merged commit 561a2af into elixir-lang:master Feb 19, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@milmazz milmazz deleted the epub_guides branch February 19, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants