Reject bidirectional formatting characters #11391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
commented
Nov 15, 2021
|
What do you think about warning on homoglyphs/confusables? https://www.unicode.org/Public/security/10.0.0/confusables.txt |
|
@fertapric yes, that's a separate problem. Ideally we will merge this with the existing StringTokenizer. We don't need to keep all confusables, only the confusables that are currently valid as identifiers. And we can probably do it all with a single pass. |
ericmj
approved these changes
Nov 15, 2021
| assert_eval_raise SyntaxError, | ||
| ~r"nofile:1:13: invalid bidirectional formatting character in string: \\u202A. If you want to use such character, use it in its escaped \\u202A form instead", | ||
| '"this is a \\\u202A"' | ||
| end |
There was a problem hiding this comment.
Do we need a test that it is accepted in escaped form?
There was a problem hiding this comment.
My answer would be no. We always accept any encoded form.
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.