Update prewalk and postwalk documentation #11874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
May 29, 2022
josevalim
reviewed
May 29, 2022
josevalim
reviewed
May 29, 2022
josevalim
reviewed
May 29, 2022
Co-authored-by: Eksperimental <eksperimental@autistici.org>
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the example for
prewalk/2is a bit confusing since some people might assume that5 + 3 * 7is transformed to5 * 3 + 7while in reality it's transformed into something like5 * (3 + 7)because the tree shape is not changed.I think by showing the previous and new AST in the example can be more helpful for the developer.
I also added an example for
prewalk/3and included some references to these functions in thepostwalk/2andpostwalk/3