Fix IEx tests on OTP27: fix assertions

[sabiwara]

Opening this PR for discussion.

We migrated IEx introspection to use :shell_docs in #12803, but OTP27 stops returning specs, which would be a regression for us.

Before (type)

After (type)

(The opaque information got lost as well, not great)

Before (spec)

After (spec)

It might be fine given we're aiming at replacing typespecs with set-theoretic types, but I wanted to confirm.
Or should we open an issue upstream?

[lukaszsamson]

You can fall back to reading specs via Code.Typespec

[sabiwara]

You can fall back to reading specs via Code.Typespec

This would basically imply reverting #12803 and go back to generating it ourselves rather than relying on :shell_docs though right? This is what I wanted to confirm.

[josevalim]

Btw, OTP 27 has markdown docs. So maybe we should use our own rendering structure for Erlang if the content type is markdown?

[garazdawi]

Another alternative is to wait for erlang/otp#8077 to be merged, then you can continue to use shell_docs for rendering erlang docs.

[josevalim]

Good point. So maybe it is best to wait until the next release candidate is out and then we can assess all of our options more throughly? @sabiwara

[sabiwara]

Good point. So maybe it is best to wait until the next release candidate is out and then we can assess all of our options more throughly?

Sounds good!
Thank you for the quick reply @garazdawi !

[sabiwara]

I think this will be the last blocker to add OTP27 to the CI, once the other PRs are merged.

[josevalim]

@sabiwara we can also stop asserting for specs on tests and add an issue to introduce the specs back once 27 is out (and such an option exists). Your call. :)

[sabiwara]

Hi @garazdawi,

Another alternative is to wait for erlang/otp#8077 to be merged, then you can continue to use shell_docs for rendering erlang docs.

I was trying the master branch after 8077 has been merged, but it seems that shell_docs are not displaying specs:

master:

OTP26:

I wondered if specs are planned to be added back to :shell_docs in OTP27, or if I misunderstood.
Thank you for your support!

[garazdawi]

Yes, it is planned though it won’t make it to 27.0 as a bunch of other things popped up that needed to be done. We would be happy to accept a pr if you feel like helping out!

[sabiwara]

We would be happy to accept a pr if you feel like helping out!

I would love to! Will give it a shot.