New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that charlists cannot be used as logger metadata #13977

Merged

sabiwara merged 1 commit into elixir-lang:main from sabiwara:clarify-metadata

Nov 7, 2024

Contributor

sabiwara commented Nov 7, 2024

Clarifies the current behavior as pointed out in https://elixirforum.com/t/charlist-values-are-not-showing-up-in-logger-metadata/67256.

Alternatively, we could support it by removing this line (but it would crash on invalid charlists) or add a try/rescue with List.to_string?


          Clarify that charlists cannot be used as logger metadata

1aa514b

josevalim approved these changes

View reviewed changes

Member

josevalim left a comment

IIRC we ran into issue once we integrated with Erlang's logger, so for now I would only document the current behaviour.

sabiwara merged commit fbeccf9 into elixir-lang:main

11 checks passed

sabiwara deleted the clarify-metadata branch

November 7, 2024 07:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet