-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing ex_doc to switch to EarmarkParser #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Since we are not using many features from Earmark, depending on just the parser piece is definitely a win. I'm a little bit concerned that the split might generate more work for you (people will report issues in the "wrong" repo, syncing releases, etc) but hopefully these would be just growing pains and things will stabilise over long-term.
The split is risky and I might regret it, but I am a perfectionist and a risk taker. Ok enough psychoanalysis of an egocentric developer 😓 just as you might have noticed when upgrading Earmark beyond 1.4.7 you will use EarmarkParser anyway. |
Definitely it will remain a problem but I am prepared to deal with it. The release procedure will take more time too as the bulk of changes will be in the parser, I am just a mad man I guess ... |
👏 |
This is really great for my dev circle. Thank you so much. |
Well maybe this is a little bit early, Earmark will remain at your disposal if you prefer
If you want to wait until Earmark uses EarmarkParser for some versions or not switch at all I will not be offended (well not much)
However ultimately I'd like to use
ex_doc
as an indirect dependency inEarmark
so if you want to switch one day that would be great.This PR just gives you the option and I'll try to sync it with upstream as much as I can