Replace EasyHTML with LazyHTML #2106
Open
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/14282236172/artifacts/2887729500 |
| @@ -47,7 +47,7 @@ defmodule ExDoc.Mixfile do | |||
| {:makeup_html, ">= 0.1.0", optional: true}, | |||
| {:jason, "~> 1.2", only: :test}, | |||
| {:floki, "~> 0.0", only: :test}, | |||
There was a problem hiding this comment.
easyhtml depends on floki, it was likely used before, that's why both are listed. Looks like there is one direct usage in erlang_test.exs, which we should be able to replace with lazy_html as well :)
Suggested change
| {:floki, "~> 0.0", only: :test}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re. #2105
Is there a better way of asserting whether or not a node is matched by the CSS selectors in
ExDoc.Formatter.HTML.TemplatesTestoutputs function groupstest than the utility function I've added? I wondered if it would be possible to pattern match against the LazyHTML result's number of nodes, but I think we don't have direct access and instead only see a reference? (%LazyHTML{resource: reference()}.)