Remove duplicate entries and assets/ folder in .build file in HTML formatter #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmatter
Previously the generated `.build` file would contain these entries:
...
assets
assets/kv-observer.png
assets/logo.png
assets/logo.png
...
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/14940397840/artifacts/3097832164 |
josevalim
reviewed
May 9, 2025
lib/ex_doc/formatter/html.ex
Outdated
| generate_redirects(config, ".html")) | ||
| |> Enum.uniq() | ||
| |> Kernel.--([@assets_dir]) | ||
| |> Enum.sort() |
There was a problem hiding this comment.
Let's move this handling to the generate_build function instead? It feels it is more part of its concern. Also, do we need to exclude @assets_dir? Why is it showing up in the list in the first place?
There was a problem hiding this comment.
I have moved the logic to generate_build.
I don't think we need to list folders in the .build file. If we decide to, we should be consistent and list all the folders consistently.
It is showing up because File.cp_r!/3 returns the dirs as well as the files.
I have taken a different approach and exclude all dirs/subdirs for the assets.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the generated
.buildfile would contain these entries: