Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module highlight token #16

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Rename module highlight token #16

merged 2 commits into from
Dec 15, 2021

Conversation

jonatanklosko
Copy link
Member

@jonatanklosko jonatanklosko commented Dec 15, 2021

See #15.

Updating the highlight token from @type to @module, so that module names get the expected color on GitHub.

// Note: this implies \r\n is treated as two line breaks,
// but in our case it's fine, since multiple line breaks
// make no difference
return c == '\n' || c == '\r';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests found a new edge case when parsing axon example :)

@jonatanklosko jonatanklosko merged commit 1b3ecf7 into main Dec 15, 2021
@jonatanklosko jonatanklosko deleted the jk-module-highlight branch December 15, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant