Bump to tree-sitter 0.20.7 and regenerate parser #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sweet, I see this cutting the time it takes to tree-sitter test roughly in half! 🚀
Two minor nits:
- there's a typo in the commit message: "noticable" => "noticeable"
- no need to commit the change to
src/parser.c: the CI will create a commit for re-generating the parser on merge
connorlay
force-pushed
the
ts-build-abi-14
branch
from
2bbf70f to
0ba537d
Compare
|
@the-mikedavis Done! |
the-mikedavis
approved these changes
Oct 16, 2022
|
Thanks @connorlay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to tree-sitter 0.20.7 causes the parser to be generated for the newest ABI version 14. This includes noticeable performance improvements when parsing query files for languages like Elixir using the new
primary_state_idsfield.See tree-sitter/tree-sitter#1589 and tree-sitter/tree-sitter#1852 for more information on this change.
You can see the impact of this change by comparing how long it takes to execute
npm teston this branch compared tomaster🙂 This change should improve the initial load time of Elixir buffers in editors like Neovim and Helix that use tree-sitter-elixir for syntax highlighting.