Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Axon.Loop.handle/4 #470

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Deprecate Axon.Loop.handle/4 #470

merged 1 commit into from
Feb 1, 2023

Conversation

seanmor5
Copy link
Contributor

Goes along with streaming. The differentiator is to possibly implement some mechanism for 2 way communication with a loop running async

@josevalim
Copy link
Contributor

@seanmor5 is this just a name change? We should be able to keep the cont/halt semantics even if running async. The issue is that by the time the halt is received, you will have to process at least one other batch/epoch.

@seanmor5
Copy link
Contributor Author

Yeah this is just a name change, the main thing is that handle_event will be something explicitly fired in a loop whereas there may be an alternative handle_message or something to handle an external message sent from the caller

@seanmor5 seanmor5 merged commit 7c21ae7 into main Feb 1, 2023
@seanmor5 seanmor5 deleted the sm-deprecate-handle branch February 1, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants