Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prune tensor expr inspect results #1272

Merged
merged 7 commits into from
Jul 27, 2023
Merged

feat: prune tensor expr inspect results #1272

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db9b7ee
feat: limit exprs on inspect
polvalente Jul 27, 2023
f07cd57
prune parameters
polvalente Jul 27, 2023
8bc3219
refactor: comply with suggestions
polvalente Jul 27, 2023
aafecfe
Update expr.ex
josevalim Jul 27, 2023
7939ecd
Update expr.ex
josevalim Jul 27, 2023
de4c3c1
test: add tests for expr limit option
polvalente Jul 27, 2023
ca35458
test: add assertion to show params go away first
polvalente Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions nx/lib/nx/defn/expr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,8 +1565,45 @@ defmodule Nx.Defn.Expr do
end

def inspect(tensor, opts) do
{_, %{exprs: exprs, parameters: parameters, length: length}} =
recur_inspect(tensor, %{cache: %{}, exprs: [], parameters: [], opts: opts, length: 0})
{_,
%{
exprs: exprs,
parameters: parameters,
length: length
}} =
recur_inspect(tensor, %{
cache: %{},
exprs: [],
parameters: [],
opts: opts,
length: 0
})

exprs =
cond do
opts.limit == 0 ->
[{"...", ""}]

length(exprs) > opts.limit ->
[h | t] = exprs
[h | Enum.take(t, opts.limit - 1)] ++ [{"...", ""}]

true ->
exprs
end

parameters =
cond do
opts.limit == 0 ->
[{"...", ""}]

(len = length(parameters)) > opts.limit ->
[h | t] = parameters
[h, {"...", ""} | Enum.drop(t, len - opts.limit)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(len = length(parameters)) > opts.limit ->
[h | t] = parameters
[h, {"...", ""} | Enum.drop(t, len - opts.limit)]
length(parameters) > opts.limit ->
[h | t] = parameters
[h, {"...", ""} | Enum.take(t, -(opts.limit - 1))]


true ->
parameters
end
Copy link
Contributor Author

@polvalente polvalente Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this prints:

Nx.default_backend(Nx.Defn.Expr)
param_tensor = &Nx.Defn.Expr.parameter(Nx.Defn.Expr.tensor(&1), &2)
Enum.reduce(1..50, param_tensor.(0, 0), &Nx.add(&2, param_tensor.(&1, &1))) |> IO.inspect(limit: 10); nil
#Nx.Tensor<
  s64
  
  Nx.Defn.Expr
  parameter a:0     s64
  parameter b:1     s64
  parameter d:2     s64
  parameter f:3     s64
  parameter h:4     s64
  parameter j:5     s64
  parameter l:6     s64
  parameter n:7     s64
  parameter p:8     s64
  ...               
  parameter dv:50   s64
  ...               
  de = add dc, dd   s64
  dg = add de, df   s64
  di = add dg, dh   s64
  dk = add di, dj   s64
  dm = add dk, dl   s64
  do = add dm, dn   s64
  dq = add do, dp   s64
  ds = add dq, dr   s64
  du = add ds, dt   s64
  dw = add du, dv   s64
>


concat(line(), color("Nx.Defn.Expr", :map, opts))
|> append_lines(parameters, length + 3)
Expand Down
Loading