refactor: Nx.Random.key as deftransform #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Sep 4, 2024
|
Good call! |
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
josevalim
reviewed
Sep 4, 2024
| seed | ||
|
|
||
| %Nx.Tensor{} = seed when seed.type == {:s, 64} -> | ||
| Nx.bitcast(seed, {:u, 64}) |
There was a problem hiding this comment.
Do we really need this clause? No-one should be passing s64 now.
There was a problem hiding this comment.
Or do we also want to do bitcasts for f64?
There was a problem hiding this comment.
We do logical and with another :u64, so that's good.
There was a problem hiding this comment.
I added the s64 case because there are explicit tests for this, and it has the same entropy as u64. Not sure about floats.
There was a problem hiding this comment.
Oh I misread the question. I think it's fair to assume seed is always an integer.
No preference on {:s, 64}, if there are tests, then yeah, bitcast sounds good.
josevalim
reviewed
Sep 4, 2024
josevalim
approved these changes
Sep 4, 2024
jonatanklosko
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.