Fix Plug.Conn.Status.reason_phrase/1 error message #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message referenced the atom `:unavailable_for_legal_reasons`, but should read `:not_an_rfc_status_code`.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Plug.Conn.Status.reason_phrase/1is called with an error code not defined by Plug or via configuration, the message of the ArgumentError that's raised references the atom:unavailable_for_legal_reasons. According to the example code above and below the text, it should instead reference:not_an_rfc_status_code.Here's hoping
HTTP 998 Not An RFC Status Codeis never proposed 😆I hope this typo PR isn't too noisy—it seems worthwhile to correct the confusing error message.