Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Converter in Front Matter #112

Closed
andyl opened this issue Oct 20, 2024 · 2 comments · Fixed by #114
Closed

Specify Converter in Front Matter #112

andyl opened this issue Oct 20, 2024 · 2 comments · Fixed by #114

Comments

@andyl
Copy link
Contributor

andyl commented Oct 20, 2024

Thanks very much for 0.18, especially for the ability to specify a converter module in config.exs. (eg md: MyMdConverter, ...).

I ran into a problem while migrating elixir-lang.org from Jekyll to Tableau:

  • elixir-lang.org uses Liquid templates
  • I have run into bugs with Elixir's Liquid processor (called Solid)
  • The bugs occur with Liquid tags for conditionals and loops, maybe others
  • When these bugs are encountered, it would be nice to just rewrite the broken page using EEx tags

With Tableau, AFAIK it's possible to set a default Layout module in config.exs, then override the layout with page front-matter.

Feature request: analogous to Layouts, allow the Converter to be set with front-matter

---
title: "My Page" 
layout: MyApp.CustomLayout
permalink: /mypage
converter: MyApp.CustomConverter
---
# Hello World
....
@mhanberg
Copy link
Collaborator

Seems reasonable.

If you can reproduce the bugs in solid could you report those to the project? Just to be a good citizen 🫡

@andyl
Copy link
Contributor Author

andyl commented Oct 20, 2024

can you report?

FYI here's the first one. edgurgel/solid#144 More to come.

andyl added a commit to andyl/tableau that referenced this issue Oct 28, 2024
…#112)

Allow a page or post to specify a custom converter in the frontmatter.

The frontmatter key `:converter` is optional.  If included, it should
specify a string-value of a converter module.  If not included, the
default config setting will be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants