README.md: Improve instructions about async tests with Phoenix #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To provide example configuration when an application has additional resources (above just the SQL database) that should be shared between processes. See elixir-wallaby#591
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 24 24
Lines 939 939
=======================================
Hits 862 862
Misses 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I tested this out to make sure I could follow the instructions and it works great! |
Closed
|
Great. I like the name of your repo 🙂 |
jonleighton
added a commit
to jonleighton/bamboo
that referenced
this pull request
Aug 8, 2021
This provides a way to receive emails from other processes without resorting to shared mode and synchronous tests. For background, this builds on some work that I did to allow Wallaby tests to play nicely with Mox, while still allowing the tests to be async. I wrote about it here: https://jonleighton.name/2021/asynchronous-browser-tests-with-phoenix/ And then contributed some docs to Wallaby about the setup here: elixir-wallaby/wallaby#592 This commit basically implements a kind of Mox.allow/3 function for Bamboo.TestAdapter. Note that I’ve changed the order of the arguments for this Bamboo.TestAdapter.forward/2 function. For Mox.allow/3, the owner_pid comes first: Mox.allow(MyMock, owner_pid, child_pid) But for Bamboo.TestAdapter.forward/2, the child_pid comes first: Bamboo.TestAdapter.forward(child_pid, owner_pid) My reasoning is that in the first example we’re allowing the child_pid to access mocks defined by the owner pid. But in the second example, we’re forwarding emails FROM the child_pid TO the owner_pid. So this order of arguments seemed to make sense to me, but may be slightly confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide example configuration when an application has additional
resources (above just the SQL database) that should be shared between
processes.
See #591