Make Query.text/2 docs also point to assert_text/{2,3} #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This beefs up the docs on `Query.text/2`, which a lot of examples combine with `assert_has/2` for asserting that a particular element has some text. Pointing to `assert_has_text/{2,3}` from the docs here would have resolved a recent issue Mitch kindly helped me with [in Slack](https://elixir-lang.slack.com/archives/C4H1XRC0J/p1715093283885629) where I was trying to assert on the text of multiple nested elements.
s3cur3
changed the title
mhanberg
reviewed
May 7, 2024
lib/wallaby/query.ex
Outdated
| Test: | ||
|
|
||
| ``` | ||
| assert_has_text(session, "Unread messages: 1 message") |
There was a problem hiding this comment.
Suggested change
| assert_has_text(session, "Unread messages: 1 message") | |
| assert_text(session, "Unread messages: 1 message") |
alinmarsh
pushed a commit
to TernSystems/wallaby
that referenced
this pull request
Oct 8, 2024
…y#770) * Make Query.text/2 docs also point to assert_has_text/{2,3} This beefs up the docs on `Query.text/2`, which a lot of examples combine with `assert_has/2` for asserting that a particular element has some text. Pointing to `assert_has_text/{2,3}` from the docs here would have resolved a recent issue Mitch kindly helped me with [in Slack](https://elixir-lang.slack.com/archives/C4H1XRC0J/p1715093283885629) where I was trying to assert on the text of multiple nested elements. * Fix typo in function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This beefs up the docs on
Query.text/2, which a lot of examples combine withassert_has/2for asserting that a particular element has some text. Pointing toassert_text/{2,3}from the docs here would have resolved a recent issue Mitch kindly helped me with in Slack where I was trying to assert on the text of multiple nested elements.