[Recognizer] Add docker image #27
Conversation
mickel8
force-pushed
the
reco-docker
branch
30 times, most recently
from
e9eb083 to
514cae9
Compare
mickel8
force-pushed
the
reco-docker
branch
14 times, most recently
from
e402691 to
1781731
Compare
recognizer/config/config.exs
Outdated
| config :bundlex, :disable_precompiled_os_deps, apps: [:ex_libsrtp] | ||
|
|
There was a problem hiding this comment.
Couldn't you only disable the precompiled deps for MIX_ENV=prod. I guess the effect will be the same, but I won't have to install libsrtp for local development?
There was a problem hiding this comment.
And btw, why we don't use the bundled libsrtp?
There was a problem hiding this comment.
There is a bug when doing mix release, at least on Arch linux
There was a problem hiding this comment.
Let's remove this and for testing I will just have a patch locally
| defp commit() do | ||
| case System.cmd("git", ["rev-parse", "--short", "HEAD"]) do | ||
| {hash, 0} -> "(#{String.trim(hash)})" | ||
| _ -> "" | ||
| try do | ||
| case System.cmd("git", ["rev-parse", "--short", "HEAD"]) do | ||
| {hash, 0} -> "(#{String.trim(hash)})" | ||
| _ -> "" | ||
| end | ||
| catch | ||
| _, _ -> "" | ||
| end |
There was a problem hiding this comment.
Wouldn't it be better to 'compute' this at compile time?
There was a problem hiding this comment.
Fixed. I also resigned from reading git commit as this is problematic in our docker build (we have Dockerfile nested in recognizer subdirectory so it doesnt have access to the .git dir in its parent)
recognizer/Dockerfile
Outdated
| # - https://hub.docker.com/_/debian?tab=tags&page=1&name=bullseye-20231009-slim - for the release image | ||
| # - https://pkgs.org/ - resource for finding needed packages | ||
| # - Ex: hexpm/elixir:1.16.0-erlang-26.2.1-debian-bullseye-20231009-slim | ||
| # |
No description provided.