Skip to content

Conversation

@mickel8
Copy link
Contributor

@mickel8 mickel8 commented Dec 15, 2023

No description provided.

@mickel8 mickel8 changed the title Stop Add stop/1 Dec 15, 2023
@mickel8 mickel8 requested a review from LVala December 15, 2023 10:34
@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #15 (f6aea82) into master (3773006) will increase coverage by 0.19%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   76.68%   76.88%   +0.19%     
==========================================
  Files          13       13              
  Lines         755      757       +2     
==========================================
+ Hits          579      582       +3     
+ Misses        176      175       -1     
Files Coverage Δ
lib/ice_agent.ex 75.85% <0.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3773006...f6aea82. Read the comment docs.

README.md Outdated
def deps do
[
{:ex_ice, "~> 0.3.0"}
{:ex_ice, "~> 0.3.1"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature in patch, hmmmm...
I know it doesn't change existing API, but still...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this in minor

@mickel8 mickel8 merged commit 97993e4 into master Dec 18, 2023
@mickel8 mickel8 deleted the stop branch December 18, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants