Add DNS message encoder/decoder #28
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 79.59% 78.24% -1.36%
==========================================
Files 17 18 +1
Lines 892 1002 +110
==========================================
+ Hits 710 784 +74
- Misses 182 218 +36
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
dns
branch
2 times, most recently
from
54eda54 to
93114e6
Compare
| defp decode_type(<<1::16, data::binary>>), do: {:ok, :a, data} | ||
| defp decode_type(<<2::16, data::binary>>), do: {:ok, :ns, data} | ||
| defp decode_type(<<3::16, data::binary>>), do: {:ok, :md, data} |
There was a problem hiding this comment.
nit: wouldn't it be nicer to do @spec do_decode_type(integet()) :: {:ok, atom()} | :error like defp do_decode_type(1), do: {:ok, :a} or even validate the integer and just do defp do_decode_type(10), do: :a (do_descode_type is just and example name?
There was a problem hiding this comment.
On the one hand yes, but on the other hand I would have to handle this {:ok, class} | :error in decode_type so I am not sure that's worthy
No description provided.