Gather and handle relay candidates #34
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## relay-cand #34 +/- ##
==============================================
- Coverage 77.73% 70.27% -7.47%
==============================================
Files 25 25
Lines 1132 1265 +133
==============================================
+ Hits 880 889 +9
- Misses 252 376 +124
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
ex_turn
branch
17 times, most recently
from
c2e41ab to
78145b0
Compare
|
I am gonna add some tests in the next PR |
lib/ex_ice/ice_agent.ex
Outdated
| optional(:credential) => String.t() | ||
| } | ||
| ], | ||
| ice_transport_policy: :all | :relay | nil, |
There was a problem hiding this comment.
Why nil is a valid value? The typedoc a bit above does not list it. If this is to indicate that the value is optional, I don't think this is the correct way to spec it.
lib/ex_ice/priv/candidate_pair.ex
Outdated
| @type t() :: %__MODULE__{ | ||
| id: integer(), | ||
| local_cand: Candidate.t(), | ||
| local_cand_id: Candidate.id(), |
There was a problem hiding this comment.
I wanted to comment that the typespec of candidate ids in ExICE.Candidate and ExICE.Priv.Candidate differs (integer() in the first one, Candidate.id()) which is a super minor issue, but, for the love of god, I cannot find the place where Candidate.id is defined and I'm so dumbfounded, where is it?
There was a problem hiding this comment.
Looks like I have deleted it 🤔 Moving to integer everywhere
mickel8
changed the title
No description provided.