Don't clear entire state after moving to the failed or completed state #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving to the failed or completed state, we have been clearing the whole state, in particular we have been removing unused candidate pairs, local candidates and sockets.
Such approach makes it hard to debug connectivity issues, as when we moved to the failed state, we cannot inspect checklist pairs, requests sent and responses received (tracking requests and responses is not implemented yet).
After these changes, when the PC moves to the failed state, one will be able to get ICE transport stats and try to analyze what went wrong.