Skip to content

Conversation

@mickel8
Copy link
Contributor

@mickel8 mickel8 commented Feb 26, 2025

When moving to the failed or completed state, we have been clearing the whole state, in particular we have been removing unused candidate pairs, local candidates and sockets.

Such approach makes it hard to debug connectivity issues, as when we moved to the failed state, we cannot inspect checklist pairs, requests sent and responses received (tracking requests and responses is not implemented yet).

After these changes, when the PC moves to the failed state, one will be able to get ICE transport stats and try to analyze what went wrong.

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 81.41026% with 29 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (125a04c) to head (2b1b4a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_ice/priv/ice_agent.ex 76.04% 23 Missing ⚠️
lib/ex_ice/priv/conn_check_handler/controlled.ex 86.36% 3 Missing ⚠️
lib/ex_ice/priv/conn_check_handler/controlling.ex 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   83.12%   83.21%   +0.09%     
==========================================
  Files          25       25              
  Lines        1564     1638      +74     
==========================================
+ Hits         1300     1363      +63     
- Misses        264      275      +11     
Files with missing lines Coverage Δ
lib/ex_ice/priv/candidate_base.ex 93.33% <ø> (ø)
lib/ex_ice/priv/checklist.ex 100.00% <100.00%> (ø)
test/support/transport/mock.ex 80.00% <100.00%> (+1.42%) ⬆️
lib/ex_ice/priv/conn_check_handler/controlled.ex 91.78% <86.36%> (+15.91%) ⬆️
lib/ex_ice/priv/conn_check_handler/controlling.ex 88.88% <81.25%> (-7.27%) ⬇️
lib/ex_ice/priv/ice_agent.ex 85.57% <76.04%> (-1.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125a04c...2b1b4a5. Read the comment docs.

@mickel8 mickel8 force-pushed the state branch 19 times, most recently from 3ff9c27 to 4b6e62a Compare March 3, 2025 08:37
@mickel8 mickel8 marked this pull request as ready for review March 3, 2025 09:27
@mickel8 mickel8 merged commit 994acb5 into master Mar 3, 2025
4 checks passed
@mickel8 mickel8 deleted the state branch March 3, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants