Initial version of sending from a file #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 84.43% 85.13% +0.69%
==========================================
Files 12 14 +2
Lines 559 592 +33
==========================================
+ Hits 472 504 +32
- Misses 87 88 +1
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
send-file
branch
15 times, most recently
from
1e530ec to
c7d1ee5
Compare
mickel8
changed the title
mickel8
force-pushed
the
send-file
branch
4 times, most recently
from
e32dc24 to
2aff383
Compare
LVala
approved these changes
Dec 8, 2023
| end | ||
|
|
||
| defp handle_webrtc_message({:connection_state_change, :connected} = msg, state) do | ||
| Logger.info("#{inspect(msg)}") |
There was a problem hiding this comment.
It is more readable when we see in logs:
Connected
Starting sending ivf file
than
Starting sending ivf file
examples/send_from_file/example.exs
Outdated
|
|
||
| {rtp_packets, last_timestamp} = | ||
| Enum.map_reduce(rtp_packets, state.last_timestamp, fn rtp_packet, last_timestamp -> | ||
| # we hardcode 3000 as we know the video is in 30 FPS |
There was a problem hiding this comment.
I would elaborat on this a bit more and include that we got this value from
dividing VP8 clock rate by the frame rate (90000/30 == 3000).
examples/send_from_file/example.js
Outdated
Comment on lines
16
to
20
| pc.ontrack = event => { | ||
| const videoPlayer = document.getElementById("videoPlayer"); | ||
| videoPlayer.srcObject = event.streams[0]; | ||
|
|
||
| }; |
There was a problem hiding this comment.
Suggested change
| pc.ontrack = event => { | |
| const videoPlayer = document.getElementById("videoPlayer"); | |
| videoPlayer.srcObject = event.streams[0]; | |
| }; | |
| pc.ontrack = event => { | |
| const videoPlayer = document.getElementById("videoPlayer"); | |
| videoPlayer.srcObject = event.streams[0]; | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that are still missing: