Add VP8 depayloader #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
vp8-depayloader
branch
from
580b802 to
3035d85
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 87.02% 87.31% +0.28%
==========================================
Files 16 18 +2
Lines 771 828 +57
==========================================
+ Hits 671 723 +52
- Misses 100 105 +5
Continue to review full report in Codecov by Sentry.
|
LVala
approved these changes
Dec 21, 2023
Comment on lines
2
to
4
| @moduledoc """ | ||
| Defines VP8 payload structure stored in RTP packet payload. | ||
| """ |
Contributor
There was a problem hiding this comment.
It would be nice to include the RFCs/specs that the vp8_x.ex modules were based on.
lib/ex_webrtc/rtp/vp8_payload.ex
Outdated
| do: {:ok, tid, y, nil, rest} | ||
|
|
||
| # note that both pion and web browser always set y bit to 0 in this case | ||
| # but RFC explicitly states that y bit can be set when t is 0 and k is 1 |
Contributor
There was a problem hiding this comment.
Like the previous comment, what RFC?
mickel8
force-pushed
the
ivf-writer
branch
2 times, most recently
from
86aad4a to
8a3d93a
Compare
mickel8
force-pushed
the
vp8-depayloader
branch
from
3035d85 to
60a828c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.