Skip to content

Add removeTrack #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add removeTrack #49

merged 3 commits into from
Jan 5, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 1, 2024

No description provided.

@mickel8 mickel8 mentioned this pull request Jan 1, 2024
63 tasks
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #49 (0d4b4d7) into master (579773b) will increase coverage by 0.89%.
The diff coverage is 95.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   87.21%   88.10%   +0.89%     
==========================================
  Files          19       19              
  Lines         829      883      +54     
==========================================
+ Hits          723      778      +55     
+ Misses        106      105       -1     
Files Coverage Δ
lib/ex_webrtc/media_stream_track.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp_sender.ex 100.00% <ø> (ø)
lib/ex_webrtc/rtp_transceiver.ex 94.91% <100.00%> (+3.53%) ⬆️
lib/ex_webrtc/utils.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/peer_connection.ex 88.65% <95.45%> (+1.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579773b...0d4b4d7. Read the comment docs.

@mickel8 mickel8 force-pushed the remove-track branch 11 times, most recently from 92cd0cc to 775e112 Compare January 2, 2024 23:39
@mickel8 mickel8 marked this pull request as ready for review January 3, 2024 12:41
@mickel8 mickel8 requested a review from LVala January 3, 2024 12:41
@mickel8 mickel8 requested a review from LVala January 4, 2024 18:28
@mickel8 mickel8 merged commit e80c310 into master Jan 5, 2024
@mickel8 mickel8 deleted the remove-track branch January 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants