Add stop_transceiver/2 #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
stop-transceiver
branch
from
b6e0f82 to
f4cb9f6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 89.01% 89.02% +0.01%
==========================================
Files 24 25 +1
Lines 965 1057 +92
==========================================
+ Hits 859 941 +82
- Misses 106 116 +10
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
stop-transceiver
branch
from
f4cb9f6 to
09c8bdd
Compare
mickel8
force-pushed
the
stop-transceiver
branch
4 times, most recently
from
7276db0 to
39cbf08
Compare
mickel8
commented
Jan 8, 2024
mickel8
force-pushed
the
stop-transceiver
branch
6 times, most recently
from
11cf0ce to
72c80d6
Compare
mickel8
force-pushed
the
stop-transceiver
branch
from
72c80d6 to
a869034
Compare
LVala
reviewed
Jan 11, 2024
Comment on lines
+879
to
+880
| %RTPTransceiver{mid: nil} -> | ||
| false |
There was a problem hiding this comment.
We discussed a case when you created and immediately stopped a transceiver -- it won't be included in the initial offer and won't be removed when applying remote answer, which might be undesired.
There was a problem hiding this comment.
IMO this is a bug but that's also how the borwser behaves so I left the comment with a link to the issue
mickel8
force-pushed
the
stop-transceiver
branch
from
af84743 to
9985e40
Compare
mickel8
force-pushed
the
stop-transceiver
branch
from
9985e40 to
13beee9
Compare
LVala
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.