-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transceiver guide #56
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 25 25
Lines 1057 1057
=======================================
Hits 941 941
Misses 116 116 Continue to review full report in Codecov by Sentry.
|
4c8ac5e
to
3d06d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general remarks:
- use Grammarly or paste the text into ChatGPT and tell it to fix the grammar and punctuation,
- like I mentioned somewhere, I feel like the guide is missing a glossary, as a lot of the terminology might be obvious for us but not necessarily for someone who just used the JS API and didn't really look into SDP and stuff. I would also move the explanations of transceiver properties (
direction
etc.) there, - the guide goes quite in-depth from the very beginning, I would love to see some introductory example (maybe showing differences between just using
addTrack
and using transceivers directly) - maybe it would be nice to crate a section where all of the API functions used later on are explained (focusing on intuition),
- link to some introductory guide to WebRTC API in the beginning of the guide?
- what do you think of adding a nice diagram showing relations between transceivers/senders/transports etc. with the new
ex_doc
diagram feature?
That's it for now, but if anything comes to my mind regarding the guide, I'm going to share it.
Some general remarks:
done
Great point! However, this is quite a lot of work and the idea was to have more advanced guide for people who more or less know what webrtc is and are looking for deep understanding of transceivers and what they can do with them. I think that all of the things you listed i.e. glossary, more basic examples, diagrams, API explanation is for another section(s) and for another task. For now I would favor renaming the guide to
👍 |
Sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said earlier, maybe it would be nice to get Jellyfish guys to read through this to get and outsider's perspective, but otherwise -- sgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.