Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid order of return values from `TWCCRecorder.get_feedback/1 #73

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Feb 19, 2024

Fixes bug merged in #63, where values returned from TWCCRecorder.get_feedback/1 are assigned to invalid variables.

@LVala LVala requested a review from mickel8 February 19, 2024 12:00
@LVala LVala self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #73 (fedbaf0) into master (22d21a5) will decrease coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   88.47%   88.40%   -0.08%     
==========================================
  Files          29       29              
  Lines        1302     1302              
==========================================
- Hits         1152     1151       -1     
- Misses        150      151       +1     
Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 87.25% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d21a5...fedbaf0. Read the comment docs.

@LVala LVala merged commit f96e563 into master Feb 19, 2024
4 checks passed
@LVala LVala deleted the fix-twcc-feedbacks branch February 19, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants