Merge pull request #1182 from SumeetChougule/main

fix: Fix client.push issue and update README for Slack client verification

agent/src/index.ts

@@ -400,17 +400,20 @@ export async function initializeClients(
     elizaLogger.log("client keys", Object.keys(clients));
 
     // TODO: Add Slack client to the list
+    // Initialize clients as an object
+
+
     if (clientTypes.includes("slack")) {
         const slackClient = await SlackClientInterface.start(runtime);
-        if (slackClient) clients.push(slackClient);
+        if (slackClient) clients.slack = slackClient; // Use object property instead of push
     }
 
     if (character.plugins?.length > 0) {
         for (const plugin of character.plugins) {
-            // if plugin has clients, add those..
             if (plugin.clients) {
                 for (const client of plugin.clients) {
-                    clients.push(await client.start(runtime));
+                    const startedClient = await client.start(runtime);
+                    clients[client.name] = startedClient; // Assuming client has a name property
                 }
             }
         }

characters/trump.character.json

@@ -1,6 +1,6 @@
 {
     "name": "trump",
-    "clients": [],
+    "clients": ["slack"],
     "modelProvider": "openai",
     "settings": {
         "secrets": {},

package.json

@@ -52,6 +52,7 @@
     },
     "dependencies": {
         "@0glabs/0g-ts-sdk": "0.2.1",
+        "@ai16z/adapter-postgres": "0.1.6-alpha.4",
         "@coinbase/coinbase-sdk": "0.10.0",
         "@deepgram/sdk": "^3.9.0",
         "@vitest/eslint-plugin": "1.0.1",

packages/client-slack/README.md

@@ -78,6 +78,15 @@ settings:
 7. On the "Basic Information" page, scroll down to "App Credentials"
 8. Copy all the credentials - you'll need them in Step 3
 
+### Step 2.5: Verify Event Subscription
+Before proceeding to install the app, make sure to verify the event subscription:
+
+1. In your Slack App settings, go to "Event Subscriptions."
+2. Enter the request URL (your ngrok HTTPS URL followed by /slack/events).
+3. Slack will send a verification request to this URL.
+4. Ensure your server is running and configured to respond to the url_verification event by echoing back the challenge token provided in the request.
+5. Once verified, you will see a confirmation in your Slack app settings.
+
 ### Step 3: Configure Environment Variables
 1. Create or edit `.env` file in your project root:
    ```bash

packages/client-slack/src/environment.ts

@@ -41,4 +41,4 @@ export async function validateSlackConfig(runtime: IAgentRuntime): Promise<Slack
         }
         throw error;
     }
-} 
+}