feat: client-discord stop implementation / agent improvements #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… character client
…, improve client guards, upload clients into runtime, make startAgent return runtime
monilpat
approved these changes
Dec 13, 2024
agent/src/index.ts
Outdated
| const clientTypes = | ||
| // each client can only register once | ||
| // and if we want two we can explicitly support it | ||
| const clients:Record<string, any> = {}; |
There was a problem hiding this comment.
Thanks so much for doing this! Appreciate how hard you are grinding! Looks like a space is missing after the colon for all the type declarations here
| const farcasterClients = new FarcasterAgentClient(runtime); | ||
| farcasterClients.start(); | ||
| clients.push(farcasterClients); | ||
| // why is this one different :( |
There was a problem hiding this comment.
We could create an issue for this to standardize
|
Also addressing linter and then good to go thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low
Background
What does this PR do?
implements discord websocket disconnect
make character settings optional
implement runtime.clients as a dict
disable client in characters client
What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
Preparation for hot reloading
Documentation changes needed?
My changes should not require a change to the project documentation.