Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#1185
Risks
Low.
js-tiktoken
.Background
What does this PR do?
This PR updates the
js-tiktoken
package to include support for theo1
model. It modifies the tokenizer logic to handle the specific tokenization patterns and configurations required for theo1
model.What kind of change is this?
Why are we doing this? Any context or related work?
Including support for the
o1
model aligns with expanding the capabilities ofjs-tiktoken
to handle the latest OpenAI models. This ensures broader usability and aligns with ongoing support for new model releases.Documentation changes needed?
o1
model support.Testing
Where should a reviewer start?
Begin by reviewing changes in the tokenizer logic in
src/tokenizer.js
and the associated test cases intests/tokenizer.test.js
.Detailed testing steps
npm install
to ensure dependencies are up to date.npm test
and verify that all test cases pass.o1
model and comparing output against expected results.Example manual test: