improvement: using strict types to avoid erorrs like issue 2164 #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
#2164
Risks
Medium
Background
What does this PR do?
The key changes:
Added explicit return type Promise to the fetch function
Added explicit type RequestInit to the options object
Maintained proper ordering of URL | RequestInfo for the input parameter
What kind of change is this?
Improvements
The key changes:
Added explicit return type Promise to the fetch function
Added explicit type RequestInit to the options object
Maintained proper ordering of URL | RequestInfo for the input parameter
Issue: #2164
Documentation changes needed?
Testing
Where should a reviewer start?
core/src/generation.ts
Detailed testing steps
run pnpm build