-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update package.json of core package #2301
Conversation
these packages are being used in prod build
While I haven't seen or experience this error, can you specify how we can reproduce this error? |
@tcm390 Tavily popping up in here |
I created an empty project and added as those packages are devdependencies dont get added to the bundle and get this error |
You haven't actually made any changes? The lines of code you've replaced are identical |
Moved packages from devdependency to dependency since they are libs that are used in the src folder and are not for development (like jest, etc) |
@wtfsayo can u explain why you closed it? thanks! |
reopened |
these packages are being used in prod build and generate errors if you decide to just use this package in a project.
Background
These packages are being used under src/ folder and needs to be part of the dependencies not dev dependencies. If you try to build a project using only the core package, you will get errors that those packages are not installed