Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update package.json of core package #2301

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

kesar
Copy link
Contributor

@kesar kesar commented Jan 14, 2025

these packages are being used in prod build and generate errors if you decide to just use this package in a project.

Background

These packages are being used under src/ folder and needs to be part of the dependencies not dev dependencies. If you try to build a project using only the core package, you will get errors that those packages are not installed

image

these packages are being used in prod build
@shakkernerd
Copy link
Member

While I haven't seen or experience this error, can you specify how we can reproduce this error?

@shakkernerd
Copy link
Member

@tcm390 Tavily popping up in here

@kesar
Copy link
Contributor Author

kesar commented Jan 15, 2025

While I haven't seen or experience this error, can you specify how we can reproduce this error?

I created an empty project and added pnpm add @elizaos/core to use it. (node 23.6)

as those packages are devdependencies dont get added to the bundle and get this error

@0xSero
Copy link
Contributor

0xSero commented Jan 15, 2025

You haven't actually made any changes? The lines of code you've replaced are identical

@kesar
Copy link
Contributor Author

kesar commented Jan 15, 2025

You haven't actually made any changes? The lines of code you've replaced are identical

Moved packages from devdependency to dependency since they are libs that are used in the src folder and are not for development (like jest, etc)

@wtfsayo wtfsayo closed this Jan 15, 2025
@kesar
Copy link
Contributor Author

kesar commented Jan 15, 2025

@wtfsayo can u explain why you closed it? thanks!

@wtfsayo wtfsayo reopened this Jan 15, 2025
@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

@wtfsayo can u explain why you closed it? thanks!

reopened

@wtfsayo wtfsayo self-requested a review January 16, 2025 08:00
@wtfsayo wtfsayo merged commit d52f47b into elizaOS:develop Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants