Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dexscreener trending #2325

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

0xCardinalError
Copy link
Contributor

Adding code from #1584
to DS plugin for fetching trending, boosted and latest tokens added to dexscreener

@wtfsayo
Copy link
Member

wtfsayo commented Jan 16, 2025

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a new module for DexScreener token trends actions, expanding the plugin's functionality. Changes involve updating export statements in the index file, adding a new trendsAction.ts file with three new action classes for retrieving token data, and modifying the main plugin configuration to include these new actions.

Changes

File Change Summary
packages/plugin-dexscreener/src/actions/index.ts - Removed .ts extension from tokenAction export
- Added new export for trendsAction
packages/plugin-dexscreener/src/actions/trendsAction.ts - Added 3 new action classes: LatestTokensAction, LatestBoostedTokensAction, TopBoostedTokensAction
- Implemented API call handlers and validation methods for each action
packages/plugin-dexscreener/src/index.ts - Updated import paths
- Added new actions to plugin configuration
- Expanded plugin description

Finishing Touches

  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
packages/plugin-dexscreener/src/actions/trendsAction.ts (2)

18-32: Add error handling in createTokenMemory function

Consider adding error handling around runtime.messageManager.createMemory(memory); to handle potential exceptions.


62-65: Optimize regex patterns in validate methods

Define the regular expressions outside the methods to improve performance if they are called frequently.

Also applies to: 177-183, 295-301

packages/plugin-dexscreener/src/index.ts (1)

17-18: Improve plugin description

Simplify the description for clarity.

Suggested change:

-description:
-    "Dex Screener Plugin with Token Price Action, Token Trends, Evaluators and Providers",
+description: "DexScreener Plugin with Token Price Actions, Token Trends, Evaluators, and Providers",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61a82c5 and 4c6a5cc.

📒 Files selected for processing (3)
  • packages/plugin-dexscreener/src/actions/index.ts (1 hunks)
  • packages/plugin-dexscreener/src/actions/trendsAction.ts (1 hunks)
  • packages/plugin-dexscreener/src/index.ts (1 hunks)
🔇 Additional comments (2)
packages/plugin-dexscreener/src/actions/trendsAction.ts (1)

92-93: Validate API response structure

Before processing, ensure the API response matches the expected structure to prevent runtime errors.

Also applies to: 210-211, 328-329

packages/plugin-dexscreener/src/actions/index.ts (1)

2-2: Exporting trendsAction as expected

The new export statement correctly includes trendsAction.

@wtfsayo wtfsayo enabled auto-merge (squash) January 16, 2025 11:27
@wtfsayo wtfsayo self-requested a review January 16, 2025 11:28
@wtfsayo wtfsayo merged commit f8b9e3e into elizaOS:develop Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants