Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't continue to load if a specified file is not found #426

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

odilitime
Copy link
Collaborator

Risks

Low

Background

What does this PR do?

If you specify a file to load, don't just load default and continue if you can't find it

What kind of change is this?

UX clean up, should reduce confusion and reduce support issues

Why are we doing this? Any context or related work?

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

I tested on stable-11-17 branch

@odilitime odilitime changed the title Don't continue to load if a specified file is not found ux: don't continue to load if a specified file is not found Nov 20, 2024
@monilpat
Copy link
Collaborator

Please update the PR title other than that good to go!

@odilitime
Copy link
Collaborator Author

Where is the docs for PR titles? or what are the options?

@monilpat
Copy link
Collaborator

monilpat commented Nov 20, 2024 via email

@odilitime
Copy link
Collaborator Author

ok so the title should be fine now

@monilpat
Copy link
Collaborator

Looks like the limitations are: feat|fix|docs|style|refactor|test|chore:any description see

if [[ ! "$PR_TITLE" =~ ^(feat|fix|docs|style|refactor|test|chore):\ .+ ]]; then
                   echo "PR title does not match the required pattern."
                   exit 1
                 fi

@odilitime odilitime changed the title ux: don't continue to load if a specified file is not found fix: don't continue to load if a specified file is not found Nov 20, 2024
@monilpat
Copy link
Collaborator

LGTM! 🥇

@ponderingdemocritus ponderingdemocritus merged commit 4154da2 into elizaOS:main Nov 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants