-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coinbase plugin starting with cb commerce functionality #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive documentation for template and client configurations: - Document all available template override options - Add client configuration settings for bot and DM handling - Include JSON examples and best practices - Add configuration guidelines for Discord, Telegram and Twitter clients Part of the documentation improvement effort to help users better understand and customize their character's behavior across different platforms.
docs: add template and client configuration guide
Wrap `fastembed` in try catch to allow non node environments to build
fix: husky and pre-commit
pgoos
reviewed
Nov 22, 2024
pgoos
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @monilpat . I left one comment not blocking.
…ckages test: add linter to all packages and enable vitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Integration of a Coinbase Commerce plugin into the project, starting with charge creation functionality. This ticket covers initial support for interacting with the Coinbase Commerce API and lays the foundation for extending features to the broader Coinbase SDK.
Risks
Background
What does this PR do?
This PR introduces a plugin for interacting with the Coinbase Commerce API, enabling the creation of payment charges. It includes:
What kind of change is this?
Why are we doing this? Any context or related work?
This integration enables seamless payment handling using Coinbase Commerce, allowing users to:
Documentation changes needed?
Testing
Where should a reviewer start?
coinbaseCommercePlugin
implementation in theplugins
directory.createCharge
,getAllCharges
, andgetChargeDetails
functions to ensure proper API handling and validation.Detailed testing steps
Setup:
Test Charge Creation:
Test Fetch All Charges:
Test Fetch Charge Details:
https://drive.google.com/file/d/1GyZlESqB7UL7TL5ti--reaEi2UbpDZa8/view?usp=sharing
Deploy Notes
COINBASE_COMMERCE_KEY
set correctly.Deployment instructions
COINBASE_COMMERCE_KEY
environment variable with a valid API key.Discord username
0x8664