Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong argument correction on trustScoreProvider.ts #631

Closed
wants to merge 1 commit into from

Conversation

thedexplorer
Copy link

SimulationSellingService accepts second param as turstScoreDb, not TokenProvider

Risks

LARGE, It's not able to build the package

Background

What does this PR do?

Solve a bug.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

No need.

Discord username

0xdexplorer

SimulationSellingService accept second param as turstScoreDb not TokenProvider
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabianhug
Copy link
Contributor

Sorry, I didn't see your PR. This has just been fixed by #636. I'll adjust my check flow to reward early contributions from now on; my bad

@fabianhug fabianhug closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants