feat: Add wallet history (transactions, balances) to coinbase providers #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Enhance Providers with Wallet History (Transactions and Balances)
Risks
Low.
Background
What does this PR do?
This PR enhances the
massPayoutProvider
,tradeProvider
, andchargeProvider
to include wallet balances and recent transactions in their responses. Additionally:getWalletDetails
is introduced to:getAssetType
helper function is added to determine the asset type (e.g., ETH, USDC) for transactions.What kind of change is this?
Feature (non-breaking change which adds functionality)
This PR extends existing providers to include wallet details, making them more informative and versatile.
Why are we doing this? Any context or related work?
This enhancement allows users to:
The goal is to provide a unified source of wallet-related insights within each provider.
Documentation changes needed?
Yes.
The functionality of the affected providers now includes wallet details. The documentation should reflect:
Testing
Where should a reviewer start?
getWalletDetails
function inutils.ts
for implementation details.massPayoutProvider
,tradeProvider
, andchargeProvider
for integration of wallet details.Detailed testing steps
massPayoutProvider.get()
tradeProvider.get()
chargeProvider.get()
getAssetType
.Screenshots
Before
massPayoutProvider
Output:After
massPayoutProvider
Output:Deploy Notes
No special deployment steps are required. Ensure:
Database changes
None.
Deployment instructions
Standard deployment.