fix: embeddings for messages with urls #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
force-pushed
the
fix_url_embeddings
branch
from
a991814 to
1bc0e48
Compare
|
Look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Messages with urls were not being embedded correctly. For example,
summarize this website https://www.browserstack.com/guide/playwright-vs-puppeteerwould be processed assummarize this website https:which gives less accurate embeddingsRisks
Low
Background
What does this PR do?
What kind of change is this?
Bug fix
Documentation changes needed?
Nope
Testing
Where should a reviewer start?
Detailed testing steps