Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make twitter client polling configurable #683

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

cygaar
Copy link
Collaborator

@cygaar cygaar commented Nov 29, 2024

Relates to:

Right now it's a random value between 2-5 minutes. Instead, we should make it configurable so different agents can have different response times. This allows devs to adjust polling intervals to avoid rate limiting.

Risks

Low

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@cygaar cygaar changed the title feature: make twitter client polling configurable feat: make twitter client polling configurable Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor

@twilwa twilwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think polling should mess with anything or any datatypes being change, should be clear

packages/client-twitter/src/base.ts Show resolved Hide resolved
@twilwa twilwa merged commit a66794a into elizaOS:main Nov 30, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants