Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ClientBase to use a map for managing multiple Twitter clients by account identifier #722

Merged
merged 3 commits into from
Nov 30, 2024
+5 −4
Merged

refactor: ClientBase to use a map for managing multiple Twitter clients by account identifier #722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d2d73b
Refactor ClientBase to use a map for managing multiple Twitter client…
tcm390 Nov 30, 2024
fcfc249
clean code
tcm390 Nov 30, 2024
a13509a
clean code
tcm390 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/client-twitter/src/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class RequestQueue {
}

export class ClientBase extends EventEmitter {
static _twitterClient: Scraper;
static _twitterClients: { [accountIdentifier: string]: Scraper } = {};
twitterClient: Scraper;
runtime: IAgentRuntime;
directions: string;
Expand Down Expand Up @@ -137,11 +137,12 @@ export class ClientBase extends EventEmitter {
constructor(runtime: IAgentRuntime) {
super();
this.runtime = runtime;
if (ClientBase._twitterClient) {
this.twitterClient = ClientBase._twitterClient;
const username = this.runtime.getSetting("TWITTER_USERNAME");
if (ClientBase._twitterClients[username]) {
this.twitterClient = ClientBase._twitterClients[username];
} else {
this.twitterClient = new Scraper();
ClientBase._twitterClient = this.twitterClient;
ClientBase._twitterClients[username] = this.twitterClient;
}

this.directions =
Expand Down
Loading