feat: implement advanced coinbase trading #725

monilpat · 2024-11-30T17:42:22Z

Relates to:

Implements advanced Coinbase trading functionality in the Eliza plugin system.

Risks:

Medium: This feature introduces significant additions to the Coinbase plugin, including trading APIs and CSV management, which may lead to potential integration challenges or runtime errors.
Potential Impact: Any misconfiguration could affect trading workflows and user experience.

Background:

What does this PR do?

This PR integrates advanced trading capabilities using the Coinbase Advanced Trading API. Key features include:

Advanced Trade Action: Enables agents to execute trades, such as buying/selling assets, using the Coinbase Advanced Trading API.
Trade Management: Maintains a CSV log of executed trades for historical tracking.
Trade Provider: Fetches account, product, and trade data for agent interactions.

What kind of change is this?

Feature: Adds new functionality for advanced trading in the Coinbase plugin.

Why are we doing this?

To expand Eliza’s capabilities in handling complex financial operations, enhancing its use cases for cryptocurrency trading, portfolio management, and automated financial workflows.

Documentation changes needed?

My changes require a change to the project documentation.
Documentation updates include the trade schema, usage examples, and integration steps for configuring API keys.

Testing:

Where should a reviewer start?

Review the implementation of executeAdvancedTradeAction and tradeProvider in packages/plugin-coinbase/src/plugins/advancedTrade.ts.

Detailed testing steps:

Set up Coinbase API and private keys in the runtime environment.
Test the EXECUTE_ADVANCED_TRADE action with valid trade inputs (e.g., asset pair, side, amount).
Verify the trade details in the generated CSV log and Coinbase dashboard.
Test error handling with invalid trade parameters or missing API keys.

TEST RESULTS:

https://drive.google.com/file/d/1uHS7fwULvdJOy9ORG6R-9Phh5ewvb08a/view?usp=sharing

Deploy Notes:

No additional deployment steps are required beyond ensuring that the Coinbase Advanced Trading API credentials are configured securely.

Discord username:

If applicable, mention your Discord username here for coordination in the #development-feed channel.

0x8664

…cedTrading

…ral/coinabseAdvancedTrading

jkbrooks · 2024-12-08T02:27:42Z

@monilpat

Failed CI

Run pnpm run lint

> eliza@ lint /home/runner/work/eliza/eliza
> bash ./scripts/lint.sh

Linting package: plugin-conflux
No lint script found in plugin-conflux, skipping lint...
Linting package: client-direct
Running lint for package: client-direct

> @ai1[6](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:7)z/client-direct@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/client-direct/src/api.ts
Warning:   56:[7](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:8)5  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-direct/src/index.ts
Warning:    5[8](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:9):15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    5[9](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:10):15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    64:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   433:52  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted client-direct

Linting package: plugin-aptos
Running lint for package: plugin-aptos

> @ai16z/plugin-aptos@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-aptos/src/actions/transfer.ts
Warning:   30:37  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted plugin-aptos

Linting package: plugin-image-generation
Running lint for package: plugin-image-generation

> @ai16z/plugin-image-generation@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted plugin-image-generation

Linting package: client-github
Running lint for package: client-github

> @ai16z/client-github@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-github

Linting package: plugin-evm
No lint script found in plugin-evm, skipping lint...
Linting package: create-eliza-app
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-08T02_23_35_706Z-debug-0.log
Running lint for package: create-eliza-app

> create-eliza-app@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/create-eliza-app/src/index.ts
Warning:   55:25  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted create-eliza-app

Linting package: client-discord
Running lint for package: client-discord

> @ai16z/client-discord@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/client-discord/src/actions/chat_with_attachments.ts
Warning:   136:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/download_media.ts
Warning:   88:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/summarize_conversation.ts
Warning:   196:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/transcribe_media.ts
Warning:   1[10](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:11):18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/index.ts
Warning:   [11](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:12)4:61  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   114:70  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   363:56  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/messages.ts
Warning:    45:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    48:32  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   230:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/utils.ts
Warning:    91:[12](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:13)  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   102:32  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/voice.ts
Warning:    210:66  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    381:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    390:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    393:36  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    952:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    958:25  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    979:49  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1023:50  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1024:70  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 21 problems (0 errors, 21 warnings)

Successfully linted client-discord

Linting package: client-auto
Running lint for package: client-auto

> @ai16z/client-auto@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-auto

Linting package: client-telegram
Running lint for package: client-telegram

> @ai16z/client-telegram@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-telegram

Linting package: plugin-trustdb
Running lint for package: plugin-trustdb

> @ai16z/plugin-trustdb@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted plugin-trustdb

Linting package: plugin-flow
Running lint for package: plugin-flow

> @ai16z/plugin-flow@0.1.5-alpha.0 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-flow/src/actions/transfer.ts
Warning:    43:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   240:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-flow/src/providers/wallet.provider.ts
Warning:    99:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   106:31  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-flow/src/tests/wallet.test.ts
Warning:   56:33  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted plugin-flow

Linting package: plugin-starknet
Running lint for package: plugin-starknet

> @ai16z/plugin-starknet@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-starknet/src/providers/token.ts
Warning:   568:62  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-starknet/src/providers/trustScoreProvider.ts
Warning:   35:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-starknet/src/utils/ERC20Token.ts
Warning:   24:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 3 problems (0 errors, 3 warnings)

Successfully linted plugin-starknet

Linting package: plugin-whatsapp
Running lint for package: plugin-whatsapp

> @ai16z/plugin-whatsapp@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/client.ts
Warning:   19:58  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/handlers/message.handler.ts
Warning:   7:51  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/handlers/webhook.handler.ts
Warning:   34:42  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   40:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/index.ts
Warning:   23:58  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted plugin-whatsapp

Linting package: adapter-sqlite
Running lint for package: adapter-sqlite

> @ai16z/adapter-sqlite@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/adapter-sqlite/src/index.ts
Warning:   437:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted adapter-sqlite

Linting package: plugin-goat
No lint script found in plugin-goat, skipping lint...
Linting package: plugin-buttplug
No lint script found in plugin-buttplug, skipping lint...
Linting package: adapter-supabase
Running lint for package: adapter-supabase

> @ai16z/adapter-supabase@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/adapter-supabase/src/index.ts
Warning:   338:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted adapter-supabase

Linting package: plugin-coinbase
Running lint for package: plugin-coinbase

> @ai16z/plugin-coinbase@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/advancedTrade.ts
Warning:   105:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Error:   155:18  error    Unexpected constant condition             no-constant-condition
Warning:   2[13](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:14):19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/commerce.ts
Warning:   [14](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:15)0:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   332:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   397:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/massPayments.ts
Warning:    86:59  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   243:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   298:68  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/tokenContract.ts
Warning:    57:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   286:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/trade.ts
Warning:    75:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1[15](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:16):19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/webhooks.ts
Warning:   76:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/types.ts
Warning:    27:41  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    49:43  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    77:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   142:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   151:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   152:27  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   182:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   196:42  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   217:13  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 23 problems (1 error, 22 warnings)

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /home/runner/work/eliza/eliza/packages/plugin-coinbase
npm error workspace @ai[16](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:17)z/plugin-coinbase@0.1.5-alpha.5
npm error location /home/runner/work/eliza/eliza/packages/plugin-coinbase
npm error command failed
npm error command sh -c eslint . --fix
Lint failed for plugin-coinbase
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

monilpat · 2024-12-08T21:32:47Z

@monilpat

Failed CI

Run pnpm run lint

> eliza@ lint /home/runner/work/eliza/eliza
> bash ./scripts/lint.sh

Linting package: plugin-conflux
No lint script found in plugin-conflux, skipping lint...
Linting package: client-direct
Running lint for package: client-direct

> @ai1[6](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:7)z/client-direct@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/client-direct/src/api.ts
Warning:   56:[7](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:8)5  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-direct/src/index.ts
Warning:    5[8](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:9):15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    5[9](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:10):15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    64:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   433:52  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted client-direct

Linting package: plugin-aptos
Running lint for package: plugin-aptos

> @ai16z/plugin-aptos@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-aptos/src/actions/transfer.ts
Warning:   30:37  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted plugin-aptos

Linting package: plugin-image-generation
Running lint for package: plugin-image-generation

> @ai16z/plugin-image-generation@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted plugin-image-generation

Linting package: client-github
Running lint for package: client-github

> @ai16z/client-github@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-github

Linting package: plugin-evm
No lint script found in plugin-evm, skipping lint...
Linting package: create-eliza-app
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-08T02_23_35_706Z-debug-0.log
Running lint for package: create-eliza-app

> create-eliza-app@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/create-eliza-app/src/index.ts
Warning:   55:25  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted create-eliza-app

Linting package: client-discord
Running lint for package: client-discord

> @ai16z/client-discord@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/client-discord/src/actions/chat_with_attachments.ts
Warning:   136:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/download_media.ts
Warning:   88:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/summarize_conversation.ts
Warning:   196:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/actions/transcribe_media.ts
Warning:   1[10](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:11):18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/index.ts
Warning:   [11](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:12)4:61  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   114:70  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   363:56  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/messages.ts
Warning:    45:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    48:32  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   230:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/utils.ts
Warning:    91:[12](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:13)  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   102:32  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/client-discord/src/voice.ts
Warning:    210:66  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    381:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    390:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    393:36  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    952:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    958:25  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    979:49  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1023:50  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1024:70  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 21 problems (0 errors, 21 warnings)

Successfully linted client-discord

Linting package: client-auto
Running lint for package: client-auto

> @ai16z/client-auto@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-auto

Linting package: client-telegram
Running lint for package: client-telegram

> @ai16z/client-telegram@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted client-telegram

Linting package: plugin-trustdb
Running lint for package: plugin-trustdb

> @ai16z/plugin-trustdb@0.1.5-alpha.5 lint
> eslint . --fix

Successfully linted plugin-trustdb

Linting package: plugin-flow
Running lint for package: plugin-flow

> @ai16z/plugin-flow@0.1.5-alpha.0 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-flow/src/actions/transfer.ts
Warning:    43:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   240:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-flow/src/providers/wallet.provider.ts
Warning:    99:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   106:31  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-flow/src/tests/wallet.test.ts
Warning:   56:33  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted plugin-flow

Linting package: plugin-starknet
Running lint for package: plugin-starknet

> @ai16z/plugin-starknet@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-starknet/src/providers/token.ts
Warning:   568:62  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-starknet/src/providers/trustScoreProvider.ts
Warning:   35:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-starknet/src/utils/ERC20Token.ts
Warning:   24:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 3 problems (0 errors, 3 warnings)

Successfully linted plugin-starknet

Linting package: plugin-whatsapp
Running lint for package: plugin-whatsapp

> @ai16z/plugin-whatsapp@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/client.ts
Warning:   19:58  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/handlers/message.handler.ts
Warning:   7:51  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/handlers/webhook.handler.ts
Warning:   34:42  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   40:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-whatsapp/src/index.ts
Warning:   23:58  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 5 problems (0 errors, 5 warnings)

Successfully linted plugin-whatsapp

Linting package: adapter-sqlite
Running lint for package: adapter-sqlite

> @ai16z/adapter-sqlite@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/adapter-sqlite/src/index.ts
Warning:   437:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted adapter-sqlite

Linting package: plugin-goat
No lint script found in plugin-goat, skipping lint...
Linting package: plugin-buttplug
No lint script found in plugin-buttplug, skipping lint...
Linting package: adapter-supabase
Running lint for package: adapter-supabase

> @ai16z/adapter-supabase@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/adapter-supabase/src/index.ts
Warning:   338:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (0 errors, 1 warning)

Successfully linted adapter-supabase

Linting package: plugin-coinbase
Running lint for package: plugin-coinbase

> @ai16z/plugin-coinbase@0.1.5-alpha.5 lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/advancedTrade.ts
Warning:   105:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Error:   155:18  error    Unexpected constant condition             no-constant-condition
Warning:   2[13](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:14):19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/commerce.ts
Warning:   [14](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:15)0:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   332:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   397:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/massPayments.ts
Warning:    86:59  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   243:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   298:68  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/tokenContract.ts
Warning:    57:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   286:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/trade.ts
Warning:    75:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   1[15](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:16):19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/plugins/webhooks.ts
Warning:   76:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/home/runner/work/eliza/eliza/packages/plugin-coinbase/src/types.ts
Warning:    27:41  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    49:43  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:    77:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   142:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   151:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   152:27  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   182:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   196:42  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Warning:   217:13  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 23 problems (1 error, 22 warnings)

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /home/runner/work/eliza/eliza/packages/plugin-coinbase
npm error workspace @ai[16](https://github.com/ai16z/eliza/actions/runs/12218038867/job/34083020492?pr=725#step:7:17)z/plugin-coinbase@0.1.5-alpha.5
npm error location /home/runner/work/eliza/eliza/packages/plugin-coinbase
npm error command failed
npm error command sh -c eslint . --fix
Lint failed for plugin-coinbase
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

Resolved :)

snobbee

LGTM, please add some test results as well in comment thanks

monilpat · 2024-12-08T21:46:56Z

LGTM, please add some test results as well in comment thanks

Cool already there in the g drive link :)

monilpat added 8 commits November 30, 2024 09:40

feat: implement advanced coinbase trading

5c2499a

feat: implement advanced coinbase trading

dfde39c

Merge branch 'temp-advanced-trading' into realitySpiral/coinabseAdvan…

938f313

…cedTrading

Merge branch 'main' of https://github.com/ai16z/eliza into realitySpi…

85f58e3

…ral/coinabseAdvancedTrading

Merge branch 'main' of https://github.com/ai16z/eliza into realitySpi…

08329f9

…ral/coinabseAdvancedTrading

get build run working

27b86b3

testing and getting advanced trading working

0a6fb91

get working

649f21c

monilpat marked this pull request as ready for review December 8, 2024 02:08

monilpat added 3 commits December 7, 2024 18:08

Merge branch 'main' of https://github.com/ai16z/eliza into realitySpi…

f5e95d7

…ral/coinabseAdvancedTrading

pnpm lock from rerunning

5803d8b

linter

47f5737

monilpat added 2 commits December 7, 2024 18:40

actually fix linter :)

05e0f86

add advanced trade folder

0c3a4a7

snobbee approved these changes Dec 8, 2024

View reviewed changes

jkbrooks approved these changes Dec 8, 2024

View reviewed changes

jkbrooks merged commit 5a2994e into elizaOS:main Dec 8, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement advanced coinbase trading #725

feat: implement advanced coinbase trading #725

monilpat commented Nov 30, 2024 •

edited

Loading

jkbrooks commented Dec 8, 2024

monilpat commented Dec 8, 2024

snobbee left a comment

monilpat commented Dec 8, 2024

feat: implement advanced coinbase trading #725

feat: implement advanced coinbase trading #725

Conversation

monilpat commented Nov 30, 2024 • edited Loading

Relates to:

Risks:

Background:

What does this PR do?

What kind of change is this?

Why are we doing this?

Documentation changes needed?

Testing:

Where should a reviewer start?

Detailed testing steps:

Deploy Notes:

Discord username:

jkbrooks commented Dec 8, 2024

monilpat commented Dec 8, 2024

snobbee left a comment

Choose a reason for hiding this comment

monilpat commented Dec 8, 2024

monilpat commented Nov 30, 2024 •

edited

Loading