Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recentPosts always empty #756

Merged
merged 2 commits into from
Dec 1, 2024
Merged

fix: recentPosts always empty #756

merged 2 commits into from
Dec 1, 2024

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Dec 1, 2024

related: #679

PR Description:

Unified Room ID Handling:
Ensures consistency by using the same room ID when creating and retrieving memories addressing an issue where {{recentPosts}} in post.ts/twitter was always empty.

Added Missing timestamp Property for Tweets:
Introduced the missing timestamp property to tweets, enabling accurate retrieval of the creation date for recent posts.

@tcm390 tcm390 requested a review from lalalune December 1, 2024 15:58
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work can we add a screengrab confirming this fixes the issues? thanks so much!

@lalalune lalalune merged commit 0ef8f2a into main Dec 1, 2024
4 checks passed
@lalalune lalalune deleted the tcm-twitter-recent-post branch December 1, 2024 22:52
@tcm390
Copy link
Collaborator Author

tcm390 commented Dec 2, 2024

Great work can we add a screengrab confirming this fixes the issues? thanks so much!

Apologies for the delayed response, I missed your earlier message.

I’ve tested the fix using two agents running simultaneously:

First Agent: https://x.com/IBGDRGNAI
Below is the screenshot confirming the issue is resolved. The recent posts are displayed correctly, and the date is accurate:

Screenshot 2024-12-01 at 7 12 10 PM

Second Agent: https://x.com/JayChou11879
Similarly, here is the screenshot showing the correct results for this agent as well:

Screenshot 2024-12-01 at 7 12 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants