fix: Refactor image interface and update to move llama cloud -> together provider #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalalune
changed the title
monilpat
reviewed
Dec 2, 2024
| width: options.width || 1024, | ||
| height: options.height || 1024, | ||
| ...(options.count !== undefined | ||
| ? { count: options.count || 1 } |
There was a problem hiding this comment.
!= null for these as we probably want the {} on null and undefined.
There was a problem hiding this comment.
Will change to ...(options.count != null ? { count: options.count || 1 } : {}),
monilpat
reviewed
Dec 2, 2024
packages/core/src/models.ts
Outdated
| @@ -107,6 +107,7 @@ export const models: Models = { | |||
| [ModelClass.EMBEDDING]: "llama-3.1-8b-instant", | |||
| }, | |||
| }, | |||
| // TODO: Remove LLAMACLOUD and just use Together | |||
There was a problem hiding this comment.
Should we create an issue for this so it doesn't get lost? Thanks so much!
monilpat
approved these changes
Dec 2, 2024
lalalune
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates #752 and also updates to move TOGETHER to not be LLAMA_CLOUD since we have lots of llama clouds now :)