Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hyperbolic api to eliza #828

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

meppsilon
Copy link
Contributor

Relates to:

Risks

Low

Background

What does this PR do?

This PR adds hyperbolic as a new model provider.

What kind of change is this?

Features (non-breaking change which adds functionality)

Why are we doing this? Any context or related work?

Add more model providers to provide a more diverse set of model offerings. As another huge plus, hyperbolic is in the web3 space: offering decentralized services for inference and building a verification mechanism for decentralized inference.

Documentation changes needed?

Any documentation necessary for adding Hyperbolic as a model provider.

Testing

I tested locally by running pnpm dev with a new character that had ModelProviderName.HYPERBOLIC as the modelProvider. Everything seemed to work well.

Where should a reviewer start?

Register at https://app.hyperbolic.xyz.
Visit https://app.hyperbolic.xyz/settings, grab your api key, and add to your .env file under HYPERBOLIC_API_KEY

Detailed testing steps

None, automated tests are fine.

Discord username

mtrz

@meppsilon meppsilon marked this pull request as ready for review December 3, 2024 21:54
@monilpat
Copy link
Collaborator

monilpat commented Dec 4, 2024

Thanks for working on this! Do you mind updating the modelprovider documentation with this new addition as well as add this Register at https://app.hyperbolic.xyz/.
Visit https://app.hyperbolic.xyz/settings, grab your api key, and add to your .env file under HYPERBOLIC_API_KEY on it thanks!

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README otherwise good to go :)

@meppsilon meppsilon changed the title Add hyperbolic api to eliza feat: add hyperbolic api to eliza Dec 4, 2024
@meppsilon
Copy link
Contributor Author

@monilpat thanks for the review! It looks like the documentation updates are run via pnpm build and because my repo is a fork, it updates all the package links in the documentations to point to my forked repo (https://github.com/meppsilon/eliza). Is there a better way to generate that? Also, in what file would you like me to place the text about grabbing the hyperbolic api key?

@meppsilon meppsilon requested a review from monilpat December 5, 2024 20:38
@meppsilon
Copy link
Contributor Author

Hey @monilpat , I manually updated a couple of the model documentation files. Let me know where you would like me to add the info about grabbing the hyperbolic api key.

@meppsilon
Copy link
Contributor Author

hey @monilpat, I see that the ModelProviderName.md has been updated and now conflicts with my PR but it looks like the conflicts are changing code references to your fork of the codebase. Do you want me to go with those changes?

@monilpat
Copy link
Collaborator

monilpat commented Dec 9, 2024

Feel free to go ahead with your changes - we need to resolve the how docs get generated so it doesn't flood PRs, but feel free to use your local changes after rebasing on top of main :) Thanks for doing this :)

@meppsilon
Copy link
Contributor Author

@monilpat No problem! Okay, I resolved the conflicts with my changes. Let me know if there's anything else you'd like for me to add into this PR.

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@@ -17,6 +17,8 @@ GOOGLE_GENERATIVE_AI_API_KEY= # Gemini API key
ALI_BAILIAN_API_KEY= # Ali Bailian API Key
VOLENGINE_API_KEY= # VolEngine API Key

HYPERBOLIC_API_KEY= # Hyperbolic API Key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add the link to api in the comments thanks otherwise LGTM!

@jkbrooks jkbrooks merged commit 736ebda into elizaOS:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants