-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base-ragsearch-plugin #944
base: develop
Are you sure you want to change the base?
Conversation
@alextitonis I just reviewed this PR, and I have a suggestion: This implementation seems more suited to being an Adapter, similar to existing ones like PostgreSQL, Supabase, or SQL Adapters. Could you refactor it into an Adapter with all the relevant functions required for seamless integration? Additionally, to ensure usability and proper testing, could you include an example demonstrating how this Adapter can be used with an Agent Client for testing purposes? This will help verify the implementation and provide a practical use case. |
It's not meant to be used as a normal database as it's using a graph for storing data, but as an extra layer, that's why i made it like that. |
Looks great to me! Could you integrate this plugin with the Agent Client, following the same approach used for other plugin integrations? |
Tried to follow the other plugins, is there something wrong? can fix it. |
Hi @alextitonis, Could you include the plugin initialization in agent/src/index.ts, similar to how the other plugins have been integrated? This will ensure consistency across the project. Also, it might be a good idea to define some actions so your plugin can be utilized effectively. By attaching the plugin to specific actions, it can seamlessly integrate into the workflow. Let me know if you’d like any support with this! |
3163ce2
to
b8b9ae9
Compare
Rebased to developer and added initialization, would be perfect if you could help with the action example |
Relates to:
Risks
Low, it's an external plugin
Background
What does this PR do?
Adds support for neo4j, users can add documents etc and do rag graph using the provider
What kind of change is this?
Documentation changes needed?
Testing
You can add the provider and try adding some docs and then use the query
Where should a reviewer start?
Detailed testing steps