fix: use MAX_TWEET_LENGTH from setting #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
reviewed
Dec 10, 2024
packages/client-twitter/src/utils.ts
Outdated
| const tweetChunks = splitTweetContent(content.text); | ||
| const tweetChunks = splitTweetContent( | ||
| content.text, | ||
| Number(client.runtime.getSetting("MAX_TWEET_LENGTH")) |
There was a problem hiding this comment.
what happens if this is not set? will passing a falsish value into splitTweetContent cause a problm?
odilitime
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Background
What does this PR do?
A follow-up PR of #912 where some code weren't updated.
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps